Add some exception logging.
authorEwan Mellor <ewan@xensource.com>
Thu, 14 Dec 2006 15:10:47 +0000 (15:10 +0000)
committerEwan Mellor <ewan@xensource.com>
Thu, 14 Dec 2006 15:10:47 +0000 (15:10 +0000)
Signed-off-by: Ewan Mellor <ewan@xensource.com>
tools/python/xen/xend/XendStorageRepository.py

index a16a293191f5e257934a8ca85224c7cd7fc49617..0aaa4c67251fdd19ce67217f683cf2a6b82fba2f 100644 (file)
@@ -20,6 +20,7 @@
 #
 
 import commands
+import logging
 import os
 import stat
 import threading
@@ -35,7 +36,10 @@ XEND_STORAGE_QCOW_FILENAME = "%s.qcow"
 XEND_STORAGE_VDICFG_FILENAME = "%s.vdi.xml"
 QCOW_CREATE_COMMAND = "/usr/sbin/qcow-create %d %s"
 
-MB = 1024 *1024
+MB = 1024 * 1024
+
+log = logging.getLogger("xend.XendStorageRepository")
+
 
 class DeviceInvalidError(Exception):
     pass
@@ -89,8 +93,7 @@ class XendStorageRepository:
                 open(uuid_file, 'w').write(new_uuid + '\n')
                 return new_uuid
         except IOError:
-            # TODO: log warning
-            pass
+            log.exception()
 
         return uuid.createString()
 
@@ -229,8 +232,7 @@ class XendStorageRepository:
                     if cfg_path and os.path.exists(cfg_path):
                         os.unlink(cfg_path)
                 except OSError:
-                    # TODO: log warning
-                    pass
+                    log.exception()
                 del self.images[image_uuid]
                 return True
         finally: